outputs: add docs around v1.5 out_es change to ES type; copyedits #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in v1.5, the default `type` was changed, which can cause problems. Highlighted this in the upgrade notes and added a 'FAQ' to the `out_es` page. - since v1.5 introduces aws auth support, added more text to highlight that `AWS\_Region` is required. If not, it dies at runtime. Seems like it could be inferred, but at least the docs reflect it a little better. - minor copyedits throughout. Signed-off-by: ted <ted@timmons.me>
tedder
force-pushed
the
ted/out_es_updates
branch
from
6ea6144 to
b34194d
Compare
Signed-off-by: ted <ted@timmons.me>
tedder
force-pushed
the
ted/out_es_updates
branch
from
5a56bab to
914173d
Compare
Signed-off-by: ted <ted@timmons.me>
Signed-off-by: ted <ted@timmons.me>
Contributor
Author
|
okay, done with the minor revisions, PR is ready. Please let me know if you have feedback, or if you'd like me to squash it into a single commit. |
Contributor
Member
|
you can squash the commits , then I can put it back in 1.5 branch |
PettitWesley
approved these changes
Jul 15, 2020
Member
|
thanks |
edsiper
pushed a commit
that referenced
this pull request
Jul 15, 2020
* add docs around v1.5 out_es change to ES type; ce - in v1.5, the default `type` was changed, which can cause problems. Highlighted this in the upgrade notes and added a 'FAQ' to the `out_es` page. - since v1.5 introduces aws auth support, added more text to highlight that `AWS\_Region` is required. If not, it dies at runtime. Seems like it could be inferred, but at least the docs reflect it a little better. - minor copyedits throughout. Signed-off-by: ted <ted@timmons.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typewas changed, which can cause problems. Highlighted this in the upgrade notes and added a 'FAQ' to theout_espage.AWS\_Regionis required. If not, it dies at runtime. Seems like it could be inferred, but at least the docs reflect it a little better.cc @edsiper because it builds on the commit you just made about ES types, @PettitWesley for general AWS knowledge.