http_server: v1: metrics: fix potential SIGSEGV by memory allocation errors #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors This is a follow up on PR 3045. While 3045 fixed the potential SIGSERV issue caused by memory allocation error in flb_avro, after searching/reviewing it looks like src/http_server/api/v1/metrics.c also consists of several similar issues. This PR adds proper check to prevent the potential SIGSERV issues. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on PR #3045. While #3045 fixed the potential SIGSERV
issue caused by memory allocation error in flb_avro, after searching/reviewing
it looks like src/http_server/api/v1/metrics.c also consists of several
similar issues.
This PR adds proper check to prevent the potential SIGSERV issues.
Signed-off-by: Yong Tang yong.tang.github@outlook.com
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.