in_http: fix parser memory reinitialization [2.0 backport] #7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tszshingt
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
This fixes the reinitialization of the parser with the size of the parser struct instead of the size of a parser function. The original code appeared to be a typo and prevented the build for Windows with this plugin. Also enabled in_http plugin in Windows cmake file. Note: this is a backport of fluent#7407 Signed-off-by: Shing Tsoi <tszshingt@yahoo.com.hk> enabled in_http
tszshingt
force-pushed
the
in_http-fix-memset-v2.0
branch
from
921fb3f
to
690d041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the reinitialization of the parser with the size of the parser struct instead of the size of a parser function. The original code appeared to be a typo and prevented the build for Windows with this plugin.
Note: this is a backport of #7407
Addresses #7008
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.