Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose flush_time_count and slow_flush_count metrics #100

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@bai
Copy link
Contributor

commented Jun 21, 2019

Expose flush_time_count and slow_flush_count metrics that were implemented in fluent/fluentd#2450.

@bai bai force-pushed the bai:more-int-metrics branch 2 times, most recently from 5079c76 to fbb205c Jun 21, 2019
@kazegusuri kazegusuri self-requested a review Jun 22, 2019
@bai bai marked this pull request as ready for review Jul 1, 2019
@ganmacs
ganmacs approved these changes Jul 1, 2019
Copy link
Member

left a comment

Thank you! looks good 👍

@ganmacs

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

@bai bai force-pushed the bai:more-int-metrics branch from fbb205c to 2d5f1bd Jul 1, 2019
@bai

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Done, thanks for feedback 👍

Signed-off-by: Vlad Gorodetsky <v@gor.io>
@bai bai force-pushed the bai:more-int-metrics branch from 2d5f1bd to 7e06abe Jul 2, 2019
@bai

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

This is ready for review 👀

@kazegusuri kazegusuri merged commit 86dd4ff into fluent:master Jul 21, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kazegusuri

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2019

Thanks! 💯

@repeatedly

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

@kazegusuri Do you have a chance to release new version?

@kazegusuri

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

OK to release a new version. Could you do that?

@repeatedly

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Yeah, I can do it. Which version is better, 1.5.0 or 1.4.1?

@kazegusuri

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

1.5.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.