Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'@' prefix for type and id #500

Closed
repeatedly opened this issue Dec 8, 2014 · 1 comment
Closed

'@' prefix for type and id #500

repeatedly opened this issue Dec 8, 2014 · 1 comment
Labels

Comments

@repeatedly
Copy link
Member

@repeatedly repeatedly commented Dec 8, 2014

In v1 configuration, we add @ prefix for system keyword or symbol to avoid parameter conflict, @label, @include and etc. I think type and id are also @ prefix parameters.

Forcing @ is high-cost so accepting type / id and writing document with @ are better for smooth migration.

What do you think?

@tagomoris
Copy link
Member

@tagomoris tagomoris commented Dec 8, 2014

👍

repeatedly added a commit that referenced this issue Dec 10, 2014
Accept '@type' and '@id' in v1 configuration. fixes #500
repeatedly added a commit that referenced this issue Dec 11, 2014
Accept '@type' and '@id' in v1 configuration. fixes #500
Conflicts:
	lib/fluent/agent.rb
	lib/fluent/config/v1_parser.rb
	lib/fluent/root_agent.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.