Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate in_object_space to v0.14 API #1076

Merged
merged 3 commits into from Jul 12, 2016

Conversation

Projects
None yet
2 participants
@cosmo0920
Copy link
Contributor

commented Jul 4, 2016

No description provided.

cosmo0920 added some commits Jul 4, 2016

@log.error_backtrace
end
end

def configure(conf)

This comment has been minimized.

Copy link
@tagomoris

tagomoris Jul 6, 2016

Member

Could you remove this method definition? No need to leave it here (just calling super).

@timer = TimerWatcher.new(@emit_interval, true, log, &method(:on_timer))
@loop.attach(@timer)
@thread = Thread.new(&method(:run))
timer_execute(:object_space_input, @emit_interval, &method(:on_timer))
end

def shutdown

This comment has been minimized.

Copy link
@tagomoris

tagomoris Jul 6, 2016

Member

Remove this method definition because it just calls super.

@tagomoris tagomoris added the v0.14 label Jul 6, 2016

Remove needless methods
`#configure` and `#shutdown` just call super.
We can omit them in plugin.
@tagomoris

This comment has been minimized.

Copy link
Member

commented Jul 12, 2016

LGTM. Thank you for contribution!

@tagomoris tagomoris merged commit 7980f69 into fluent:master Jul 12, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cosmo0920 cosmo0920 deleted the cosmo0920:migrate-in_object_space-to-v0.14 branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.