Fix fluent-cat command to send sub-second precision time #1277

Merged
merged 2 commits into from Oct 17, 2016

Projects

None yet

2 participants

@repeatedly
Member

Fix #1276

@repeatedly repeatedly Fix fluent-cat command to send sub-second precision time
49e1a55
@repeatedly
Member

@tagomoris If no problem, I will merge this.

lib/fluent/command/cat.rb
@@ -200,7 +202,8 @@ def write_impl(array)
end
begin
- socket.write [@tag, array].to_msgpack
+ packer = Fluent::Engine.msgpack_factory.packer
@tagomoris
tagomoris Oct 17, 2016 Member

It's better to use Fluent::MessagePackFactory.packer than using Fluent::Engine, because it makes internal dependency problem minimized.

@tagomoris
Member

I pointed just one problem. Outline and others look good to me.

@repeatedly repeatedly Use MessagePackFactory instead of Engine for getting packer
a7461f1
@repeatedly repeatedly merged commit bf83168 into master Oct 17, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@repeatedly
Member

Applied reviews and test passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment