fix not to raise error when out_forward is initialized as secondary #1313

Merged
merged 1 commit into from Nov 15, 2016

Projects

None yet

2 participants

@tagomoris
Member

fixes #1310.

@tagomoris tagomoris fix not to raise error when out_forward is initialized as secondary
572d656
@tagomoris tagomoris added the v0.14 label Nov 15, 2016
@tagomoris
Member

@repeatedly could you review this change?

@repeatedly
Member

LGTM

@tagomoris tagomoris merged commit 3f41f70 into master Nov 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tagomoris tagomoris deleted the fix-forward-output-crashing-as-secondary branch Nov 15, 2016
@repeatedly
Member

Time to release v0.14.9?

@tagomoris
Member

I want to include #1312 into v0.14.9 if possible. Do you think this issue is critical?

@repeatedly
Member

Yes and I assume #1312 will be merged in the next week because you can't write the code tomorrow.
We can release v0.14.10 after merged #1312, so pending v0.14.9 has no merit for users.

@tagomoris
Member

No problem for me, but i can't do release (write release notes) right now.
@repeatedly Can I ask you to do it?

@repeatedly
Member

Okay. I will do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment