fix not to check tag and variable placeholders when configured as secondary #1338

Merged
merged 1 commit into from Dec 6, 2016

Projects

None yet

2 participants

@tagomoris
Member
tagomoris commented Nov 30, 2016 edited

out_file has been used as plugin to dump data in secondary for a long time, and
that configuration looses consistency about chunk keys (even in v0.12).
But increment placeholder of out_file can create another file name (by just numbering) for such cases.

This change makes v0.14 to work with such configuration...

This fixes #1330.

@tagomoris tagomoris fix not to check tag and variable placeholders when configured as sec…
…ondary

out_file has been used as plugin to dump data in secondary for a long time, and
that configuration looses consistency about chunk keys (even in v0.12).
But increment placeholder of out_file can create another file name (by just numbering) for such cases.

This change makes v0.14 to work with such configuration...
075e89a
@tagomoris
Member

@repeatedly could you review this change?

@repeatedly
Member

LGTM.

Further improvement, how about warning message like "For secondary, using secondary_file instead of file is recommended"?

@tagomoris
Member

It's not bad but a bit troublesome to show that message only when primary plugin is NOT out_file plugin.

@tagomoris tagomoris merged commit 63eb1f2 into master Dec 6, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tagomoris tagomoris deleted the fix-to-skip-check-for-placeholders-as-secondary-out_file branch Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment