Add priority_key/facility_key options to in_syslog #1351

Merged
merged 1 commit into from Dec 8, 2016

Projects

None yet

3 participants

@knqyf263
Contributor
knqyf263 commented Dec 6, 2016

I want that priority and facility are in event record.
Currently, I use fluent-plugin-record-reformer to extract priority and facility values from tags.

However, these values have already been parsed in in_syslog plugin.
https://github.com/fluent/fluentd/blob/406c2a1dbfe0c2f14618b9251b67bc1e4f637813/lib/fluent/plugin/in_syslog.rb#L172-L173

I think it is useless to use another plugin for extracting priority and facility.
Then, I added include_priority/facility options to in_syslog.

@repeatedly
Member

in_tcp's source_hostname_key approach is better than include_priority because someone wants to specify key.

@knqyf263
Contributor
knqyf263 commented Dec 6, 2016

@repeatedly Thanks for your feedback!
I fixed. How about this?

@knqyf263 knqyf263 closed this Dec 6, 2016
@knqyf263 knqyf263 reopened this Dec 6, 2016
@knqyf263 knqyf263 Add priority_key/facility_key options to in_syslog
d3680f3
@knqyf263 knqyf263 changed the title from Add include_priority/facility options to in_syslog to Add priority_key/facility_key options to in_syslog Dec 6, 2016
@tagomoris
Member

LGTM.

@tagomoris tagomoris assigned repeatedly and tagomoris and unassigned repeatedly and tagomoris Dec 7, 2016
@repeatedly repeatedly merged commit 66fb153 into fluent:master Dec 8, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@knqyf263
Contributor
knqyf263 commented Dec 8, 2016

Thanks!
How about a document?
Shoud I send a PR to fluent/fluentd-docs ? 0.12 or 0.14 ?

@repeatedly
Member

I will backport this feature to v0.12 so v0.12 is enough.

@knqyf263 knqyf263 referenced this pull request in fluent/fluentd-docs Dec 8, 2016
Merged

Add priority_key/facility_key options to in_syslog #249

@knqyf263
Contributor
knqyf263 commented Dec 8, 2016

OK!
I sent a PR.
fluent/fluentd-docs#249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment