formatter_csv: Change fields parameter to required #1361

Merged
merged 3 commits into from Dec 14, 2016

Projects

None yet

2 participants

@repeatedly
Member

Empty fields is error prone because it generates empty line.

@tagomoris
Member

IMO it should raise error for empty field configured.

@repeatedly
Member

It seems good > raise when fields is empty.

@repeatedly
Member

Review applied. After test passed, will merge.

@tagomoris
Member

Please send another pull-req to master branch right now to raise error for empty fields.
It may make regressions if missed now.

@repeatedly repeatedly merged commit e5fbc57 into v0.12 Dec 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@repeatedly repeatedly deleted the change-csv-field-to-required branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment