Add slow_flush_log_threshold parameter #1366

Merged
merged 4 commits into from Dec 14, 2016

Projects

None yet

2 participants

@repeatedly
Member

This is useful for debugging of buffer flush issue.

I set default value is 5.0. This is good for local destination but 5.0 seems small for cloud based services.
Should we set large value for default setting?

This patch is for v0.12 but support this feature in v0.14 is also good.

@tagomoris
Member

slow_flush_log_threshold?

@repeatedly
Member

It is also good. I refer long_query_time in mysql first.
Adding log is no problem for me.

@repeatedly
Member

Rename and change default values.

@repeatedly
Member

After test passed, I will merge this patch.

@tagomoris
Member

Could you create a pull-request for master branch before merging?
I want to make it sure to port this feature to v0.14.

@repeatedly repeatedly changed the title from Add slow_flush_threshold parameter to Add slow_flush_log_threshold parameter Dec 13, 2016
@repeatedly repeatedly merged commit 8b3fe04 into v0.12 Dec 14, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@repeatedly repeatedly deleted the log-slow-flush branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment