Fix bug to ignore some command line options #1398

Merged
merged 2 commits into from Jan 4, 2017

Projects

None yet

2 participants

@tagomoris
Member

Currently, supervisor overwrites values from command line options by system config values (even if no parameters are configured in <system> sections).
This makes a bug to ignore some command line options, which can be configured via both of command line options and system config section (For example, --suppress-config-dump).

This change makes command line options prior than system config parameters.
It's just standard way in all daemon software.

@tagomoris tagomoris fix to update system_config instances by values from command line opt…
…ions
6de5a26
@tagomoris tagomoris requested a review from repeatedly Jan 4, 2017
@tagomoris
Member

@repeatedly could you review this?

@tagomoris tagomoris fix not to overwrite system config always by false value
4ad6543
@repeatedly
Member

LGTM

@tagomoris tagomoris merged commit a64f77d into master Jan 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tagomoris tagomoris deleted the fix-to-enable-command-line-options branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment