record_transformer: remove_keys processing should be last #1433

Merged
merged 1 commit into from Jan 26, 2017

Projects

None yet

2 participants

@repeatedly
Member

Currently, remove_keys doesn't work with renew_time_key parameter, so
user needs one more filter to remove renew_time_key field from the record.

<filter pattern>
  @type record_transformer
  renew_time_key event_time
  auto_typecast true
  <record>
    event_time ${Convert record["time_str"] into unixtime or float type}
  </record>
</filter>

<filter pattern>
  @type record_transformer
  remove_keys event_time
</filter>

This is verbose and not good performance. remove_keys should remove renew_time_key.

<filter pattern>
  @type record_transformer
  renew_time_key event_time
  remove_keys event_time
  auto_typecast true
  <record>
    event_time ${Convert record["time_str"] into unixtime or float type}
  </record>
</filter>
@repeatedly repeatedly record_transformer: remove_keys processing should be last
19d4e04
@repeatedly repeatedly requested a review from sonots Jan 25, 2017
@repeatedly
Member

@sonots Could you check this patch?

@sonots
Member
sonots commented Jan 26, 2017

LGTM

@sonots sonots referenced this pull request in sonots/fluent-plugin-record-reformer Jan 26, 2017
Merged

remove_keys processing should be last #46

@repeatedly repeatedly merged commit 1adaa0f into master Jan 26, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment