New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Support record_accessor in buffer's chunk keys #1662

Merged
merged 2 commits into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@repeatedly
Member

repeatedly commented Aug 10, 2017

This patch add record_accessor's dot-notation support in chunk keys.
To support bracket-notation, we need to consider relax validation in many places.
So it is the future work.

@repeatedly

This comment has been minimized.

Show comment
Hide comment
@repeatedly

repeatedly Aug 15, 2017

Member

@mururu Could you check this?

Member

repeatedly commented Aug 15, 2017

@mururu Could you check this?

@@ -36,7 +37,7 @@ class Output < Base
helpers_internal :thread, :retry_state
CHUNK_KEY_PATTERN = /^[-_.@a-zA-Z0-9]+$/
CHUNK_KEY_PLACEHOLDER_PATTERN = /\$\{[-_.@a-zA-Z0-9]+\}/
CHUNK_KEY_PLACEHOLDER_PATTERN = /\$\{[-_.@$a-zA-Z0-9]+\}/

This comment has been minimized.

@mururu

mururu Aug 15, 2017

Member

Why do we have to add $?

@mururu

mururu Aug 15, 2017

Member

Why do we have to add $?

This comment has been minimized.

@repeatedly

repeatedly Aug 15, 2017

Member

Without $, we can't put $ inside placeholders like ${$.nested.key}.

@repeatedly

repeatedly Aug 15, 2017

Member

Without $, we can't put $ inside placeholders like ${$.nested.key}.

This comment has been minimized.

@mururu

mururu Aug 15, 2017

Member

I got it.

@mururu

mururu Aug 15, 2017

Member

I got it.

@mururu

mururu approved these changes Aug 15, 2017

LGTM

@repeatedly repeatedly merged commit c7e94e8 into master Aug 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@repeatedly repeatedly deleted the support-record-accessor-in-chunk-keys branch Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment