Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_parser: Fix dumpped result for avoiding escape sequence injection #1733

Merged
merged 1 commit into from Nov 7, 2017

Conversation

repeatedly
Copy link
Member

Escape sequence is affected when user launches fluentd without log option in the console.

@repeatedly repeatedly merged commit 3be7587 into v0.12 Nov 7, 2017
@repeatedly repeatedly deleted the fix-parser-log-escape branch November 7, 2017 05:31
@MarwanBayadsi
Copy link

MarwanBayadsi commented Dec 13, 2017

hi,
In which version of td-agent i can get this fix ? I checked in v0.12 releases and didnt find it.

@repeatedly
Copy link
Member Author

Yes, latest td-agent 2 doesn't include this fix yet.
We don't have new td-agent 2 plan for this patch because td-agent use-case doesn't have this problem for now.

@chaosoldier
Copy link

chaosoldier commented Dec 21, 2017

hi,

Please tell me when will this fixed version (0.12.41) be available on the yum rpm repository?
https://github.com/fluent/fluentd/blob/v0.12/CHANGELOG.md#bug-fixes
https://td-agent-package-browser.herokuapp.com/2/redhat/6/x86_64

use-case doesn't have this problem for now.

Is this comment means the injenction will be safe for all use-case??
https://docs.treasuredata.com/articles/td-agent-changelog

@repeatedly
Copy link
Member Author

repeatedly commented Dec 21, 2017

Is this comment means the injenction will be safe for all use-case??

If you use td-agent with default way, yes. If you use vanilla fluentd directly with no log / daemonize option in td-agent, this problem happens.
If you want to use latest version in existing td-agent, update fluentd to latest is one way.

@chaosoldier
Copy link

thank you for answering my question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants