From 0b33b433e02e3d13d6d105aff697abdbb99e68f3 Mon Sep 17 00:00:00 2001 From: Dennis Doomen Date: Thu, 10 Feb 2022 17:54:27 +0100 Subject: [PATCH] Updated PR template --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3ba69d7192..c16ffc299e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,7 +1,7 @@ ## IMPORTANT * [ ] The code complies with the [Coding Guidelines for C#](https://www.csharpcodingguidelines.com/). -* [ ] The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used [in this example](https://github.com/fluentassertions/fluentassertions/blob/daaf35b9b59b622c96d0c034e8972a020b2bee55/Tests/FluentAssertions.Shared.Specs/BasicEquivalencySpecs.cs#L33). -* [ ] If the contribution adds a feature or fixes a bug, please update [**the release notes**](https://github.com/fluentassertions/fluentassertions/tree/master/docs), which are published on the [website](https://fluentassertions.com/releases). -* [ ] If the contribution changes the public API the changes needs to be included by running `AcceptApiChanges.ps1`/`AcceptApiChanges.sh`. -* [ ] If the contribution affects [the documentation](https://github.com/fluentassertions/fluentassertions/tree/develop/docs/_pages), please include your changes in this pull request so the documentation will appear on the [website](https://www.fluentassertions.com/introduction). \ No newline at end of file +* [ ] The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming convetions such as is used [in these tests](https://github.com/fluentassertions/fluentassertions/blob/174d2621a988ffa1fcaff8b2d531c71f9b3b56ec/Tests/FluentAssertions.Equivalency.Specs/MemberMatchingSpecs.cs#L51-L430). +* [ ] If the PR adds a feature or fixes a bug, please update [**the release notes**](https://github.com/fluentassertions/fluentassertions/tree/develop/docs) with a functional description that explains what the change means to consumers of this library, which are published on the [website](https://fluentassertions.com/releases). +* [ ] If the PR changes the public API the changes needs to be included by running `AcceptApiChanges.ps1`/`AcceptApiChanges.sh`. +* [ ] If the PR affects [the documentation](https://github.com/fluentassertions/fluentassertions/tree/develop/docs/_pages), please include your changes in this pull request so the documentation will appear on the [website](https://www.fluentassertions.com/introduction). \ No newline at end of file