Rename WhichValue to WhoseValue #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
May 26, 2021
|
Do we have some documentation examples that also needs to be updated? |
jnyrup
approved these changes
May 29, 2021
Did a quick scan, but apparently we never documented this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize this has sort of been discussed in #577 and #1126, but without any real conclusion, which I think is unfortunate. However, in the case of WhichValue (on a dictionary), there can never be any ambiguity and "Which" will always be the wrong word. It could be argued that it should rather be something like "WhoseCorrespondingValue", since the Value does not belong to the Key, but that's a bit long.