New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency on System.Xml.Linq #79
Comments
That's because it offers specific assertions for XML types. But what's your problem with its dependency? |
I understand the reason. |
But that would mean splitting off the XML stuff into a dedicated assembly. However, I still don't see why this is such a big deal for you. Isn't it just a unit test project? It's not like you're going to ship that project, aren't you? |
If FluentAssertions has this dependency, why doesn't the NuGet-package show this as a dependency? |
It's something from the past. |
What do you mean?
I created a new Unit Test Project (.NET Framework) in VS2019, added FluentAssertions, and tried to use it, but I had to manually add System.Xml.Linq using NuGet Package Manager. Ah, but if I create a new MSTest Test Project (.NET Core) I do not have to ad System.Xml.Linq. I suppose that is what you mean by "something from the past" then. I think the NuGet package should have a dependency on System.Xml.Linq for its .NETFramework v4.7 and v4.5 targets. |
Yeah, you're right. Somehow we lost that dependency. |
Thanks for reopening the issue, but technically, the issue I mentioned is not the same as this issue. You still won't remove the dependency on System.Xml.Linq, but you will (re)add it to the package. |
You're right @comecme. |
Version 5.6.0 seems to be the most recent version, which includes the dependency on System.Xml.Linq. So downgrading is a temporary solution. |
I don't understand what you mean. Version 5.6.0 is not the most recent version (5.9.0 is the most recent). Also, version 5.6.0 only has no dependencies for .NETFramework,Version=v4.7. |
I'm the offender #1009 . |
Noticed this problem while creating a few brand new projects on the full framework. We have this habit of sending a commit for the project creation, and then adding the tests later. Immediately when trying to add the tests, we'd be hit with the requirement to then add What's the status on this one? I tend to agree with @abatishchev and would prefer a separate |
This has been fixed on |
I did not have time to try it yet, but it does not seem to be fixed. Or not completely. If I install version 5.10.0 into a .NET 4.7.1 Framework unit test project, no dependencies are installed. When I use But I do get a message telling me I need to install System.Xml.
|
Ah, so we also need to add |
Fixed in 5.10.1 |
Hey, I encountered this issue in v6 - I've downgraded to 5.10.3 and it seems to be working OK for me now |
Why would you downgrade? You can always add the missing dependency. Is there any? Which target framework are you using? |
Discovered this issue on version 6.6.0 and 6.8.0. The error is:
My project is using dotnet 6.0. Strange that it's asking me to use System.Xml.XDocument v6.0.0 as the latest version is 4.3.0 https://www.nuget.org/packages/System.Xml.XDocument/ |
@harvzor Can you share your It sounds a bit like an outdated nuget package manager or IDE that does not correctly know about |
Currently FluentAssertions.dll is tightly dependent on System.Xml.Linq.dll. Its unreferencing causes a compiler error:
Please consider re-designing to remove such necessity..
The text was updated successfully, but these errors were encountered: