Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringAssertions::NotBeEquivalentTo #1134

Merged
merged 5 commits into from
Sep 10, 2019
Merged

Add StringAssertions::NotBeEquivalentTo #1134

merged 5 commits into from
Sep 10, 2019

Conversation

danielmpetrov
Copy link
Contributor

Closes #997

jnyrup
jnyrup requested changes Sep 9, 2019
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.

Src/FluentAssertions/Primitives/StringAssertions.cs Outdated Show resolved Hide resolved
Tests/Shared.Specs/StringAssertionSpecs.cs Show resolved Hide resolved
Tests/Shared.Specs/StringAssertionSpecs.cs Outdated Show resolved Hide resolved
@danielmpetrov
Copy link
Contributor Author

Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.

Thanks for the review.

Since it's getting late now, I'll resolve these tomorrow and let you know.

dennisdoomen
dennisdoomen approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. I have only one comment/concern.

Tests/Shared.Specs/StringAssertionSpecs.cs Show resolved Hide resolved
@jnyrup jnyrup merged commit 7ba9252 into fluentassertions:master Sep 10, 2019
@danielmpetrov danielmpetrov deleted the gh_997 branch September 11, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnyrup jnyrup jnyrup approved these changes

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing StringAssertions::NotBeEquivalentTo
3 participants
@danielmpetrov @dennisdoomen @jnyrup