Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringAssertions::NotBeEquivalentTo #1134

Merged
merged 5 commits into from Sep 10, 2019

Conversation

danielmpetrov
Copy link
Contributor

@danielmpetrov danielmpetrov commented Sep 9, 2019

Closes #997

Copy link
Member

@jnyrup jnyrup left a comment

Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.

Src/FluentAssertions/Primitives/StringAssertions.cs Outdated Show resolved Hide resolved
Tests/Shared.Specs/StringAssertionSpecs.cs Show resolved Hide resolved
Tests/Shared.Specs/StringAssertionSpecs.cs Outdated Show resolved Hide resolved
@danielmpetrov
Copy link
Contributor Author

@danielmpetrov danielmpetrov commented Sep 9, 2019

Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.

Thanks for the review.

Since it's getting late now, I'll resolve these tomorrow and let you know.

Copy link
Member

@dennisdoomen dennisdoomen left a comment

Great PR. I have only one comment/concern.

Tests/Shared.Specs/StringAssertionSpecs.cs Show resolved Hide resolved
@danielmpetrov danielmpetrov requested a review from jnyrup Sep 10, 2019
jnyrup
jnyrup approved these changes Sep 10, 2019
@jnyrup jnyrup merged commit 7ba9252 into fluentassertions:master Sep 10, 2019
1 check passed
@danielmpetrov danielmpetrov deleted the gh_997 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants