Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringCollectionAssertions::ContainMatch #1138

Merged
merged 8 commits into from Sep 17, 2019

Conversation

@danielmpetrov
Copy link
Contributor

danielmpetrov commented Sep 15, 2019

Closes #482

It's an old one, but better late than never, right?

@danielmpetrov danielmpetrov requested a review from jnyrup Sep 15, 2019
@danielmpetrov

This comment has been minimized.

Copy link
Contributor Author

danielmpetrov commented Sep 16, 2019

Any additional concerns or comments in order to wrap this up? @jnyrup @dennisdoomen

@dennisdoomen

This comment has been minimized.

Copy link
Member

dennisdoomen commented Sep 17, 2019

Any additional concerns or comments in order to wrap this up?

Not from me. @jnyrup has been thorough enough 😀

@jnyrup
jnyrup approved these changes Sep 17, 2019
@jnyrup jnyrup merged commit 9a90f3a into fluentassertions:master Sep 17, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jnyrup

This comment has been minimized.

Copy link
Collaborator

jnyrup commented Sep 17, 2019

Thanks @danielmpetrov for taking the time to implement this and the additional changes 👍

@danielmpetrov danielmpetrov deleted the danielmpetrov:gh_482 branch Sep 17, 2019
@WingTai WingTai mentioned this pull request Oct 21, 2019
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.