Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of PR #989 #1140

Merged
merged 16 commits into from Sep 21, 2019
Merged

Continuation of PR #989 #1140

merged 16 commits into from Sep 21, 2019

Conversation

@danielmpetrov
Copy link
Contributor

danielmpetrov commented Sep 18, 2019

This PR is an attempt to close out #989.

Changelog since the original PR:

  • Update docs
  • Add more tests based on #989 (comment) by @jnyrup
  • The behavior implemented in regards to empty/single element collections is as suggested by @jnyrup and agreed on by @dennisdoomen (see below)

I came to think of two inherent properties of empty/single element collections.
They are:

  • always ordered, and
  • both in ascending and descending order at the same time.
  • Organized the tests for Be In Ascending/Descending Order in GenericCollectionAssertionsSpecs.cs into sub-regions for better navigation, since it was hard to find my way around. I kept the original tests, and added on a few more as stated earlier, but please check them that they make sense. 馃憤

Closes #296 and Resolves #989

docs/_pages/collections.md Outdated Show resolved Hide resolved
@dennisdoomen dennisdoomen requested a review from jnyrup Sep 18, 2019
@jnyrup jnyrup merged commit 9a3e049 into fluentassertions:master Sep 21, 2019
1 check was pending
1 check was pending
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@jnyrup

This comment has been minimized.

Copy link
Collaborator

jnyrup commented Sep 21, 2019

Thanks @david-a-jetter and @danielmpetrov for contributing this improvement

@danielmpetrov danielmpetrov deleted the danielmpetrov:gh_296 branch Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.