Continuation of PR #989 #1140
Merged
Continuation of PR #989 #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with NotBeIn and add obsolete attributes to old methods
…sertions and refactor BeOrderedBy to prevent wetness
…ollection assertions
…ds to use non obsolete implementations per feedback
dennisdoomen
approved these changes
Sep 18, 2019
jnyrup
approved these changes
Sep 21, 2019
|
Thanks @david-a-jetter and @danielmpetrov for contributing this improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to close out #989.
Changelog since the original PR:
GenericCollectionAssertionsSpecs.csinto sub-regions for better navigation, since it was hard to find my way around. I kept the original tests, and added on a few more as stated earlier, but please check them that they make sense. 👍Closes #296 and Resolves #989