Skip to content

/ fluentassertions

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect self-closing xml tags with attributes #1170

Merged
merged 1 commit into from Oct 26, 2019
Merged

Detect self-closing xml tags with attributes #1170

merged 1 commit into from Oct 26, 2019

Conversation

@jnyrup
Copy link
Collaborator

jnyrup commented Oct 25, 2019

When traversing the structure of an XDocument and into
the Attributes of an xml tag, we need to move out again
using MoveToElement() to properly detect the xml tag,
and not the attributes, as self-closing.
This fixes #1166
@dennisdoomen
dennisdoomen approved these changes Oct 26, 2019
View changes
Tests/Shared.Specs/XDocumentAssertionSpecs.cs Outdated Show resolved Hide resolved
@jnyrup
Detect self-closing xml tags with attributes
Loading status checks…
fa46521 
When traversing the structure of an `XDocument` and into
the `Attributes` of an xml tag, we need to move out again
using `MoveToElement()` to properly detect the xml tag,
and not the attributes, as self-closing.
This fixes #1166
@jnyrup jnyrup force-pushed the jnyrup:SelfClosingXmlTags branch from ade2d73 to fa46521 Oct 26, 2019
@jnyrup jnyrup merged commit edc66ab into fluentassertions:master Oct 26, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jnyrup jnyrup deleted the jnyrup:SelfClosingXmlTags branch Oct 26, 2019
@jnyrup jnyrup mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisdoomen dennisdoomen

@danielmpetrov danielmpetrov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jnyrup @dennisdoomen @danielmpetrov
You can’t perform that action at this time.