Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect self-closing xml tags with attributes #1170

Merged
merged 1 commit into from Oct 26, 2019

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Oct 25, 2019

When traversing the structure of an XDocument and into
the Attributes of an xml tag, we need to move out again
using MoveToElement() to properly detect the xml tag,
and not the attributes, as self-closing.
This fixes #1166

Tests/Shared.Specs/XDocumentAssertionSpecs.cs Outdated Show resolved Hide resolved
When traversing the structure of an `XDocument` and into
the `Attributes` of an xml tag, we need to move out again
using `MoveToElement()` to properly detect the xml tag,
and not the attributes, as self-closing.
This fixes fluentassertions#1166
@jnyrup jnyrup merged commit edc66ab into fluentassertions:master Oct 26, 2019
1 check passed
@jnyrup jnyrup deleted the SelfClosingXmlTags branch Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants