Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing failure messages #1172

Merged
merged 1 commit into from Oct 27, 2019
Merged

Conversation

@jnyrup
Copy link
Collaborator

jnyrup commented Oct 26, 2019

Some assertions did not include failure reason either because it:

  • did not add BecauseOf before invoking FailWith, or
  • did not have {reason} inside the failure message.
    I added two optional because parameters to IsCyclicReference to achieve this.
    That class is internal, so no breaking change, but if it can be done
    prettier I'm all ear.
Some assertions did not include failure reason either because it:
* did not add `BecauseOf` before invoking `FailWith`, or
* did not have {reason} inside the failure message.
I added two optional because parameters to `IsCyclicReference` to achieve this.
That class is internal, so no breaking change, but if it can be done
prettier I'm all ear.
@jnyrup jnyrup merged commit a5b48af into fluentassertions:master Oct 27, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jnyrup jnyrup deleted the jnyrup:missingReason branch Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.