Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd missing failure messages #1172
Merged
Conversation
Some assertions did not include failure reason either because it:
* did not add `BecauseOf` before invoking `FailWith`, or
* did not have {reason} inside the failure message.
I added two optional because parameters to `IsCyclicReference` to achieve this.
That class is internal, so no breaking change, but if it can be done
prettier I'm all ear.
jnyrup
merged commit a5b48af
into
fluentassertions:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jnyrup commentedOct 26, 2019
Some assertions did not include failure reason either because it:
BecauseOfbefore invokingFailWith, orI added two optional because parameters to
IsCyclicReferenceto achieve this.That class is internal, so no breaking change, but if it can be done
prettier I'm all ear.