Make ThatAreUnderNamespace respect null namespaces and prefixes
#1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
force-pushed
the
1185_ThatAreUnderNamespace
branch
from
fea0ab4 to
0d7cae5
Compare
jnyrup
changed the title
ThatAreUnderNamespace respect null namespace.ThatAreUnderNamespace respect null namespaces and prefixes
dennisdoomen
approved these changes
Dec 1, 2019
The namespace of a type not inside any namespace is `null`. As all types are *under* the global namespace, `ThatAreUnderNamespace` should be able to gracefully handle `null` namespaces. This also fixes that `ThatAreUnderNamespace` would incorrectly match the namespace of a type against a partial prefix. This fixes fluentassertions#1185 and fluentassertions#1196
jnyrup
force-pushed
the
1185_ThatAreUnderNamespace
branch
from
0d7cae5 to
30b3764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace of a type not inside any namespace is
null.As all types are under the global namespace,
ThatAreUnderNamespaceshould be able to gracefully handlenullnamespaces.This also fixes that
ThatAreUnderNamespacewould incorrectly match thenamespace of a type against a partial prefix.
This fixes #1185 and #1196