Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `ThatAreUnderNamespace` respect null namespaces and prefixes #1197

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@jnyrup
Copy link
Collaborator

jnyrup commented Nov 30, 2019

The namespace of a type not inside any namespace is null.
As all types are under the global namespace, ThatAreUnderNamespace should be able to gracefully handle null namespaces.

This also fixes that ThatAreUnderNamespace would incorrectly match the
namespace of a type against a partial prefix.

This fixes #1185 and #1196

@jnyrup jnyrup force-pushed the jnyrup:1185_ThatAreUnderNamespace branch from fea0ab4 to 0d7cae5 Nov 30, 2019
@jnyrup jnyrup changed the title Make `ThatAreUnderNamespace` respect null namespace. Make `ThatAreUnderNamespace` respect null namespaces and prefixes Nov 30, 2019
The namespace of a type not inside any namespace is `null`.
As all types are *under* the global namespace, `ThatAreUnderNamespace` should be able to gracefully handle `null` namespaces.

This also fixes that `ThatAreUnderNamespace` would incorrectly match the
namespace of a type against a partial prefix.

This fixes #1185 and #1196
@jnyrup jnyrup force-pushed the jnyrup:1185_ThatAreUnderNamespace branch from 0d7cae5 to 30b3764 Dec 5, 2019
@jnyrup jnyrup merged commit 1180d74 into fluentassertions:master Dec 5, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jnyrup jnyrup deleted the jnyrup:1185_ThatAreUnderNamespace branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.