Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Intercept Reflection exceptions from `AppSettingsConfigurationStore` #1210
Sorry for the delayed response. I was traveling over the holidays and could only look at code diffs on GitHub. I have verified the changes to intercept the reflection exceptions fix FluentAssertions for my Android builds. I also reviewed to the FluentAssertions code more closely and I understand callers to AppSettingsConfigurationStore can handle a null response. Thanks for making the change and have a happy new year. Steve From: Jonas Nyrup <firstname.lastname@example.org> Sent: Thursday, January 2, 2020 11:26 AM To: fluentassertions/fluentassertions <email@example.com> Cc: Steve Bush <firstname.lastname@example.org>; Mention <email@example.com> Subject: Re: [fluentassertions/fluentassertions] Intercept Reflection exceptions from `AppSettingsConfigurationStore` (#1210) @SteveBush<https://github.com/SteveBush> I see the inconsistency. The code here was intentional, as AppSettingsConfigurationStore can return null. Are having problems with the merged fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1210?email_source=notifications&email_token=AAVLFOVICO52KRPKK7VYPHDQ3Y5TDA5CNFSM4KA6D47KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH7E6SA#issuecomment-570314568>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAVLFOSHMR3BKKZX5VVFTKTQ3Y5TDANCNFSM4KA6D47A>.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.