Ensure that chained assertion calls are ignored when the preceding one fails #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
force-pushed
the
Fix/ChainingApi
branch
5 times, most recently
from
f4b455b
to
22f39e3
Compare
dennisdoomen
changed the title
While practicing TDD, I often have a block of TODO comments listening the scenarios I think I need to cover. This should not cause compiler errors.
dennisdoomen
force-pushed
the
Fix/ChainingApi
branch
from
22f39e3
to
bbac71c
Compare
jnyrup
reviewed
May 16, 2020
|
Nice changes, and a breeze to review due to your diligent splitting of commits |
When the initial assertion run through the AssertionScope failed, the chaining API would not ignore any following calls to Given, FailWith, etc.
dennisdoomen
force-pushed
the
Fix/ChainingApi
branch
from
bbac71c
to
6c937a4
Compare
jnyrup
approved these changes
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the initial assertion run through the AssertionScope failed, the chaining API would not ignore any following calls to Given, FailWith, etc.
Fixes #1302