Skip to content

Added CompareBy{Members,Value}(Type) - #1389

Merged
jnyrup merged 1 commit into
fluentassertions:developfrom
jnyrup:compareByOpenGenericType
Sep 19, 2020
Merged

jnyrup merged 1 commit into
fluentassertions:developfrom
jnyrup:compareByOpenGenericType

Conversation

@jnyrup

@jnyrup jnyrup commented Sep 16, 2020 •

Copy link
Copy Markdown
Member

The new overloads allows you to use an open generic type.
If both an open and closed type are specified, the closed type takes precedence.

This fixes #1388, #1023

@jnyrup
jnyrup force-pushed the compareByOpenGenericType branch from 5922af8 to ea9148f Compare September 16, 2020 19:55
@jnyrup jnyrup linked an issue Sep 16, 2020 that may be closed by this pull request
The new overloads allows you to use an open generic type.
If both an open and close type are specified, the closed type takes
precedence.

This fixes fluentassertions#1388
@jnyrup
jnyrup force-pushed the compareByOpenGenericType branch from ea9148f to 2714038 Compare September 19, 2020 15:48
@jnyrup
jnyrup requested a review from dennisdoomen September 19, 2020 15:51

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jnyrup
jnyrup merged commit dcfc419 into fluentassertions:develop Sep 19, 2020
@jnyrup
jnyrup deleted the compareByOpenGenericType branch September 20, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertEquivalencyUsing support for unbound generic types ComparingByMembers for open generic type

2 participants