Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new overload of Enumerating() (#1431) #1433

merged 3 commits into from Nov 17, 2020

Introduce new overload of Enumerating() (#1431) #1433

merged 3 commits into from Nov 17, 2020


Copy link

@mu88 mu88 commented Nov 17, 2020


  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

Copy link
Contributor Author

mu88 commented Nov 17, 2020

Any ideas why the AppVeyor build is failing? I cannot reproduce this on my machine 🤔

Copy link

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, looks good to me.

Can I ask you to make two additional changes:

  • Update docs\_pages\ with a line about the added overloads
  • Add an example in docs\_pages\ just below the func.Enumerating().Should().Throw<ArgumentException>(); example

@jnyrup jnyrup merged commit 2cca450 into fluentassertions:develop Nov 17, 2020
@jnyrup jnyrup linked an issue Nov 17, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Unexpected behavior with IEnumerable and exceptions
3 participants