Skip to content

When a dictionary does not a key, it should report the right path including the reason #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Jan 6, 2021

Sometimes BeEquivalentTo reported an incorrect message when a dictionary was missing a key.

Fixes #1450

@dennisdoomen dennisdoomen requested a review from jnyrup January 6, 2021 18:59
@dennisdoomen dennisdoomen changed the title When a dictionary does not a key, it should report the right path [WIP] When a dictionary does not a key, it should report the right path Jan 6, 2021
@dennisdoomen dennisdoomen removed the request for review from jnyrup January 6, 2021 19:07
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message probably misses a "contains".
"When a dictionary does not a key, it should report the right path"

Feel free to leave it.

@dennisdoomen
Copy link
Member Author

Yes, but I also decided to fix #1449 in the same PR tomorrow. That's why I removed the review request ;-)

@jnyrup
Copy link
Member

jnyrup commented Jan 6, 2021

Didn't see my removal and adding of [WIP] before I starting reviewing :)

@dennisdoomen dennisdoomen force-pushed the Fix/1450 branch 2 times, most recently from 6712e0e to 854d69d Compare January 7, 2021 21:31
@dennisdoomen dennisdoomen changed the title [WIP] When a dictionary does not a key, it should report the right path When a dictionary does not a key, it should report the right path Jan 7, 2021
@dennisdoomen dennisdoomen changed the title When a dictionary does not a key, it should report the right path When a dictionary does not a key, it should report the right path including the reason Jan 7, 2021
@dennisdoomen dennisdoomen changed the title When a dictionary does not a key, it should report the right path including the reason [WIP] When a dictionary does not a key, it should report the right path including the reason Jan 7, 2021
@dennisdoomen dennisdoomen changed the title [WIP] When a dictionary does not a key, it should report the right path including the reason When a dictionary does not a key, it should report the right path including the reason Jan 8, 2021
@dennisdoomen dennisdoomen merged commit 2d604d8 into fluentassertions:develop Jan 8, 2021
@dennisdoomen dennisdoomen deleted the Fix/1450 branch January 8, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes BeEquivalentTo reports incorrect message for dictionary key mismatch
2 participants