Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust Assembly assertions #1561

Merged
merged 2 commits into from May 15, 2021
Merged

Robust Assembly assertions #1561

merged 2 commits into from May 15, 2021

Conversation

eNeRGy164
Copy link
Contributor

More coverage of #1039

  • Added failure message when Subject is null
  • Added Guards against null parameters

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@dennisdoomen dennisdoomen requested a review from jnyrup May 14, 2021 13:24
@dennisdoomen
Copy link
Member

Needs, to be rebased

@eNeRGy164
Copy link
Contributor Author

Working on it, hotel wifi is not the same as my home connection :)

@dennisdoomen
Copy link
Member

Working on it, hotel wifi is not the same as my home connection :)

Not going to ask why you're working on this from a hotel room... 😜

@eNeRGy164
Copy link
Contributor Author

Working on it, hotel wifi is not the same as my home connection :)

Not going to ask why you're working on this from a hotel room... 😜

It's not like there is somewhere to go at this time of day. So, I settle on a view of the North Sea, some Cava and contributing some source ⛱️

@jnyrup jnyrup merged commit 0fc81cf into fluentassertions:develop May 15, 2021
@eNeRGy164 eNeRGy164 deleted the robust-assembly-assertions branch May 19, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants