Skip to content

Add first-class support for C# 9.0 records - #1571

Merged
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:Feature/RecordSupport
May 22, 2021
Merged

Add first-class support for C# 9.0 records#1571
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:Feature/RecordSupport

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented May 21, 2021

Copy link
Copy Markdown
Member
  • By default, records are compared by their members
  • This can be overridden by ComparingRecordsByValue or ComparingByValue<T>
  • Also improved the reporting on how types with members are compared.

Fixes #1451

@dennisdoomen
dennisdoomen force-pushed the Feature/RecordSupport branch from a99d589 to 1ec912f Compare May 22, 2021 08:23
@dennisdoomen dennisdoomen changed the title [WIP] Add support for C# 9.0 records Add support for C# 9.0 records May 22, 2021
@dennisdoomen dennisdoomen changed the title Add support for C# 9.0 records Add first-class support for C# 9.0 records May 22, 2021
@dennisdoomen
dennisdoomen requested a review from jnyrup May 22, 2021 08:25
@dennisdoomen
dennisdoomen force-pushed the Feature/RecordSupport branch from 1ec912f to 0063b7f Compare May 22, 2021 08:43
@dennisdoomen dennisdoomen modified the milestone: 6.0 May 22, 2021
Comment thread Src/FluentAssertions/Common/TypeExtensions.cs Outdated
Comment thread Tests/FluentAssertions.Specs/Equivalency/BasicEquivalencySpecs.cs Outdated
Also improved the reporting on how types with members are compared.
@dennisdoomen
dennisdoomen force-pushed the Feature/RecordSupport branch from 0063b7f to e452a29 Compare May 22, 2021 12:59
@dennisdoomen
dennisdoomen merged commit 18d7ce3 into fluentassertions:develop May 22, 2021
@dennisdoomen
dennisdoomen deleted the Feature/RecordSupport branch May 22, 2021 13:12
@rizi

rizi commented Jun 14, 2021

Copy link
Copy Markdown

@dennisdoomen what does CompareByMembers do and what does CompareByValue do, what's the difference between them when talking about records?
Sorry for asking but the naming is not so easy to understand if you are new to this project.

Br

@dennisdoomen

Copy link
Copy Markdown
Member Author

@rizi see https://github.com/fluentassertions/fluentassertions/blob/release-6.0/docs/_pages/objectgraphs.md#value-types

@rizi

rizi commented Jun 14, 2021

Copy link
Copy Markdown

@rizi see https://github.com/fluentassertions/fluentassertions/blob/release-6.0/docs/_pages/objectgraphs.md#value-types

@dennisdoomen
Thank you very much for the fast response, the docs are excellent and now the naming makes absolutely sense.
Br

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detailed message for graph comparison of C# 9 records

3 participants