Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added native support for XDocument, XElement and XAttribute properties and fields to BeEquivalentTo #1572

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented May 22, 2021

BeEquivalentTo now supports properties and fields of type XDocument, XElement and XAttribute. This will make graphs with such type behave the same way as calling BeEquivalentTo on an XElement directly. For XAttribute, we use its Be method.

  • Documentation Can't think of a good place to mention this
  • Release Notes

Fixed #1535

@dennisdoomen dennisdoomen force-pushed the Feature/XElementEquivalency branch 2 times, most recently from 99fbb11 to de2f23a Compare May 23, 2021 08:04
@dennisdoomen dennisdoomen changed the title [WIP] Have BeEquivalentTo do deep comparisons of XML structures Added native support for XDocument, XElement and XAttribute properties and fields to BeEquivalentTo May 23, 2021
@dennisdoomen dennisdoomen requested a review from jnyrup May 23, 2021 19:10
@dennisdoomen dennisdoomen merged commit 92d6397 into fluentassertions:develop May 23, 2021
@dennisdoomen dennisdoomen deleted the Feature/XElementEquivalency branch May 23, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeEquivalentTo on a graph should compare XElements using deep comparisons
2 participants