Optionally include internal members in equivalency assertions #1575
Conversation
dennisdoomen
force-pushed
the
Fix/1205
branch
5 times, most recently
from
6b43908 to
9f66ac0
Compare
dennisdoomen
changed the title
| return type | ||
| .GetProperties(AllInstanceMembersFlag) | ||
| .Where(property => property.GetMethod?.IsPrivate == false) | ||
| .Where(property => includeInternals || property.GetMethod?.IsAssembly == false) |
There was a problem hiding this comment.
How does this handle properties marked as private protected or protected internal?
There was a problem hiding this comment.
AFAIK private protected is not relevant here, but protect internal was. I've added extra tests to cover this scenario.
There was a problem hiding this comment.
I'm wondering a bit about what that means to protected members.
We ignore protected members
unless it's protected internal
unless it private protected?
| return type | ||
| .GetProperties(AllInstanceMembersFlag) | ||
| .Where(property => property.GetMethod?.IsPrivate == false) | ||
| .Where(property => includeInternals || property.GetMethod?.IsAssembly == false) |
There was a problem hiding this comment.
I'm wondering a bit about what that means to protected members.
We ignore protected members
unless it's protected internal
unless it private protected?
Why do you care about |
BeEquivalentTo will no longer include internal properties and fields, unless IncludingInternalProperties or IncludingInternalFields is used
|
I do not care about |
BeEquivalentTowill no longer includeinternalproperties and fields, unlessIncludingInternalPropertiesorIncludingInternalFieldsis usedFixes #1205, #744