Skip to content

A succeeding condition should not be evaluated if the first one failed - #1587

Merged
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:Fix/1568
May 30, 2021
Merged

A succeeding condition should not be evaluated if the first one failed#1587
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:Fix/1568

Conversation

@dennisdoomen

Copy link
Copy Markdown
Member

In a chained assertion API call, a second call to ForCondition should not even evaluate its lambda when the previous assertion failed.

Fixes #1568

In a chained assertion API call, a second call to ForCondition should not even evaluate its lambda when the previous assertion failed.
@eNeRGy164

eNeRGy164 commented May 29, 2021

Copy link
Copy Markdown
Contributor

So now we can remove all those if statements again? 🤣

@jnyrup

jnyrup commented May 29, 2021

Copy link
Copy Markdown
Member

So now we can remove all those if statements again?

Only those using a GivenSelector.

For the majority, in order to remove the ifs, we would have to first rewrite them to use a GivenSelector.

@dennisdoomen
dennisdoomen merged commit 4b83e09 into fluentassertions:develop May 30, 2021
@dennisdoomen
dennisdoomen deleted the Fix/1568 branch May 30, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ForCondition continues when wrapped in AssertionScope

3 participants