Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the type from the failure message in equivalency checks #1621

Conversation

dennisdoomen
Copy link
Member

Because the equivalency validator will use the expectation to traverse the object graph, the INode.Type property (and the Description derived from that) always refers to the type of the node from the perspective of the expectation. But this was sometimes used to refer to the subject's node, causing weird failure messages where the type matched the expectation but not the subject.

Because the equivalency validator will use the expectation to traverse the object graph, the INode.Type property always refers to the type of the node from the perspective of the expectation. But this was sometimes used to refer to the subject's node, causing weird failure messages.
@dennisdoomen dennisdoomen force-pushed the Fix/RemoveTypesFromEquivalencyOutput branch from c0bc35c to 93a13a2 Compare July 7, 2021 19:56
@dennisdoomen dennisdoomen merged commit 86a9aaf into fluentassertions:release-6.0 Jul 8, 2021
@dennisdoomen dennisdoomen deleted the Fix/RemoveTypesFromEquivalencyOutput branch July 8, 2021 08:58
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 19, 2021
All callers was removed with fluentassertions#1621
@jnyrup jnyrup mentioned this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant