New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension method `WithInnerExceptionExactly` for async exception assertions #1658

Merged

jnyrup merged 3 commits into fluentassertions:master from LennartKoot:async-ex-asserts

Aug 21, 2021

Contributor

LennartKoot commented Aug 20, 2021 •

edited

Adds extension method for the remaining method WithInnerExceptionExactly for ExceptionAssertions<T> when using ThrowAsync.

Closes #1400

LennartKoot force-pushed the async-ex-asserts branch from 42f40fe to 95c5d51 Compare

August 20, 2021 21:02

Contributor Author

LennartKoot commented Aug 20, 2021

Hmm, after second thought, the And and Which extensions method are not really useful as you still have to wrap it in an await to get the actual exception. Will drop that change.

Please let me know if I am missing a different approach to provide And and Which chaining directly after ThrowAsync. I'll happily implement it.

LennartKoot added 3 commits

August 20, 2021 23:54


          Add extensions method 'WithInnerExceptionExactly()' for async Excepti…

1d6b2a3

…onAssertions


          Update approved api

f69c87c


          Update release page

559e10b

LennartKoot force-pushed the async-ex-asserts branch from 95c5d51 to 559e10b Compare

August 20, 2021 21:56

LennartKoot changed the title ~~Add remaining extensions methods for async exception assertions~~ Add extension method WithInnerExceptionExactly for async exception assertions

dennisdoomen approved these changes

View reviewed changes

dennisdoomen requested a review from jnyrup

August 21, 2021 07:13

jnyrup approved these changes

View reviewed changes

jnyrup merged commit 8ad5e52 into fluentassertions:master

Elanis pushed a commit to Elanis/portfolio that referenced this pull request


          Bump FluentAssertions from 5.10.3 to 6.1.0 (#8)

ef87c5c

Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 5.10.3 to 6.1.0.
<details>
<summary>Release notes</summary>

*Sourced from [FluentAssertions's releases](https://github.com/fluentassertions/fluentassertions/releases).*

> ## 6.1.0
> [Release Notes](https://fluentassertions.com/releases/[#610](https://github.com/fluentassertions/fluentassertions/issues/610))
>
> ## 6.0.0
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/master/docs/_pages/releases.md#600)
>
> ## 6.0.0-beta.3
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/6.0.0-beta.3/docs/_pages/releases.md#600-beta-3)
>
> ## 6.0.0-beta.2
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/release-6.0/docs/_pages/releases.md#600-beta-2)
>
> ## 6.0.0-beta.1
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/release-6.0/docs/_pages/releases.md#600-beta-1)
>
> ## 6.0.0-alpha.2
> See [release notes](https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md#600-alpha-2).
>
> ## 6.0.0-alpha.1
> See https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md#600
</details>
<details>
<summary>Commits</summary>

- [`ce07e5c`](fluentassertions/fluentassertions@ce07e5c) Bump the release number for 6.1
- [`577d555`](fluentassertions/fluentassertions@577d555) Resolved a significant performance degradation in `BeEquivalentTo` ([#1660](fluentassertions/fluentassertions#1660))
- [`a38a54a`](fluentassertions/fluentassertions@a38a54a) Fix small grammatical error ([#1659](fluentassertions/fluentassertions#1659))
- [`8ad5e52`](fluentassertions/fluentassertions@8ad5e52) Merge pull request [#1658](fluentassertions/fluentassertions#1658) from LennartKoot/async-ex-asserts
- [`559e10b`](fluentassertions/fluentassertions@559e10b) Update release page
- [`f69c87c`](fluentassertions/fluentassertions@f69c87c) Update approved api
- [`1d6b2a3`](fluentassertions/fluentassertions@1d6b2a3) Add extensions method 'WithInnerExceptionExactly()' for async ExceptionAssert...
- [`a977427`](fluentassertions/fluentassertions@a977427) Merge pull request [#1656](fluentassertions/fluentassertions#1656) from eNeRGy164/markdown-linting
- [`d6ea6c1`](fluentassertions/fluentassertions@d6ea6c1) Update header style and add additional installation path
- [`75bfd96`](fluentassertions/fluentassertions@75bfd96) Correct white-space in documentation
- Additional commits viewable in [compare view](fluentassertions/fluentassertions@5.10.3...6.1.0)
</details>

<br />

Reviewed-on: https://gitea.dysnomia.studio/elanis/portfolio/pulls/8
Co-authored-by: elanis <elanis@noreply.example.org>
Co-committed-by: elanis <elanis@noreply.example.org>

Elanis added a commit to Dysnomia-Studio/dysnomia-website that referenced this pull request


          Bump FluentAssertions from 5.10.3 to 6.1.0 (#11)

dd0b640

Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 5.10.3 to 6.1.0.
<details>
<summary>Release notes</summary>

*Sourced from [FluentAssertions's releases](https://github.com/fluentassertions/fluentassertions/releases).*

> ## 6.1.0
> [Release Notes](https://fluentassertions.com/releases/[#610](https://github.com/fluentassertions/fluentassertions/issues/610))
>
> ## 6.0.0
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/master/docs/_pages/releases.md#600)
>
> ## 6.0.0-beta.3
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/6.0.0-beta.3/docs/_pages/releases.md#600-beta-3)
>
> ## 6.0.0-beta.2
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/release-6.0/docs/_pages/releases.md#600-beta-2)
>
> ## 6.0.0-beta.1
> [Release Notes](https://github.com/fluentassertions/fluentassertions/blob/release-6.0/docs/_pages/releases.md#600-beta-1)
>
> ## 6.0.0-alpha.2
> See [release notes](https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md#600-alpha-2).
>
> ## 6.0.0-alpha.1
> See https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md#600
</details>
<details>
<summary>Commits</summary>

- [`ce07e5c`](fluentassertions/fluentassertions@ce07e5c) Bump the release number for 6.1
- [`577d555`](fluentassertions/fluentassertions@577d555) Resolved a significant performance degradation in `BeEquivalentTo` ([#1660](fluentassertions/fluentassertions#1660))
- [`a38a54a`](fluentassertions/fluentassertions@a38a54a) Fix small grammatical error ([#1659](fluentassertions/fluentassertions#1659))
- [`8ad5e52`](fluentassertions/fluentassertions@8ad5e52) Merge pull request [#1658](fluentassertions/fluentassertions#1658) from LennartKoot/async-ex-asserts
- [`559e10b`](fluentassertions/fluentassertions@559e10b) Update release page
- [`f69c87c`](fluentassertions/fluentassertions@f69c87c) Update approved api
- [`1d6b2a3`](fluentassertions/fluentassertions@1d6b2a3) Add extensions method 'WithInnerExceptionExactly()' for async ExceptionAssert...
- [`a977427`](fluentassertions/fluentassertions@a977427) Merge pull request [#1656](fluentassertions/fluentassertions#1656) from eNeRGy164/markdown-linting
- [`d6ea6c1`](fluentassertions/fluentassertions@d6ea6c1) Update header style and add additional installation path
- [`75bfd96`](fluentassertions/fluentassertions@75bfd96) Correct white-space in documentation
- Additional commits viewable in [compare view](fluentassertions/fluentassertions@5.10.3...6.1.0)
</details>

<br />

Co-authored-by: Elanis <elanis@hotmail.com>
Reviewed-on: https://gitea.dysnomia.studio/elanis/dysnomia-website/pulls/11
Co-authored-by: elanis <elanis@noreply.example.org>
Co-committed-by: elanis <elanis@noreply.example.org>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment