Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests (according to coveralls) for Data* objects #1882

Merged
merged 7 commits into from Apr 9, 2022

Conversation

IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Apr 6, 2022

This ref. #1823

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 2113871407

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.165%

Totals Coverage Status
Change from base Build 2107562998: 0.2%
Covered Lines: 8165
Relevant Lines: 8463

💛 - Coveralls

@IT-VBFK IT-VBFK force-pushed the code-coverage branch 2 times, most recently from 9fe4577 to 846779a Compare Apr 6, 2022
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Thanks for the contribution.

The reason for this change was, to get
away from the 'When_x_it_should_be_y' approach in future.
IT-VBFK and others added 2 commits Apr 8, 2022
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup
jnyrup approved these changes Apr 8, 2022
Copy link
Member

@jnyrup jnyrup left a comment

Please squash the commits

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Apr 8, 2022

All commits into one?

@jnyrup
Copy link
Member

jnyrup commented Apr 8, 2022

All commits into one?

Yes please.

@dennisdoomen dennisdoomen merged commit db4562b into fluentassertions:develop Apr 9, 2022
1 check passed
@IT-VBFK IT-VBFK deleted the code-coverage branch Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants