Try to stabilize UIFact tests by running them sequentially
+243
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2185638942
|
dennisdoomen
reviewed
Apr 20, 2022
| @@ -84,17 +84,21 @@ public async Task When_async_method_throws_an_empty_AggregateException_it_should | |||
| await act2.Should().ThrowAsync<XunitException>(); | |||
| } | |||
|
|
|||
| [UIFact] | |||
| public async Task When_async_method_throws_an_empty_AggregateException_on_UI_thread_it_should_fail() | |||
| [Collection("UIFacts")] | |||
There was a problem hiding this comment.
I'm pretty sure that tests within the same class will never run in parallel. So moving all those tests in the same (partial) class should be enough.
There was a problem hiding this comment.
This change should also put tests across different classes in the same test collection to avoid any UIFacts being run in parallel.
dennisdoomen
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Everyone's tired of
[UIFact]tests (semi-)randomly failing and I don't have a clue what's causing the issue.I initially wanted to use https://github.com/JoshKeegan/xRetry to simply retry them, but it doesn't seem combinable with
UIFact.So instead I went with running the
[UIFact]tests sequentially and crossing fingers it'll improve things.Disable whitespace while reviewing.