Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to stabilize UIFact tests by running them sequentially

Merged
merged 1 commit into from Apr 23, 2022

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Apr 18, 2022

Everyone's tired of [UIFact] tests (semi-)randomly failing and I don't have a clue what's causing the issue.
I initially wanted to use https://github.com/JoshKeegan/xRetry to simply retry them, but it doesn't seem combinable with UIFact.

So instead I went with running the [UIFact] tests sequentially and crossing fingers it'll improve things.

Disable whitespace while reviewing.

@coveralls
Copy link

coveralls commented Apr 18, 2022

Pull Request Test Coverage Report for Build 2185638942

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.59%

Totals Coverage Status
Change from base Build 2185557425: 0.0%
Covered Lines: 8421
Relevant Lines: 8686

💛 - Coveralls

@jnyrup jnyrup requested a review from dennisdoomen Apr 19, 2022
@@ -84,17 +84,21 @@ public async Task When_async_method_throws_an_empty_AggregateException_it_should
await act2.Should().ThrowAsync<XunitException>();
}

[UIFact]
public async Task When_async_method_throws_an_empty_AggregateException_on_UI_thread_it_should_fail()
[Collection("UIFacts")]
Copy link
Member

@dennisdoomen dennisdoomen Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that tests within the same class will never run in parallel. So moving all those tests in the same (partial) class should be enough.

Copy link
Member Author

@jnyrup jnyrup Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should also put tests across different classes in the same test collection to avoid any UIFacts being run in parallel.

@jnyrup jnyrup merged commit 3634163 into fluentassertions:develop Apr 23, 2022
1 check passed
@jnyrup jnyrup deleted the UIFact_serialize branch Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants