Fix issue when an empty ArraySegment is a member of a class #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ITaluone
force-pushed
the
fix/finish-2445
branch
from
97589c8 to
d50d4e6
Compare
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 7213584218
💛 - Coveralls |
dennisdoomen
approved these changes
Dec 12, 2023
ITaluone
force-pushed
the
fix/finish-2445
branch
from
d50d4e6 to
299b12d
Compare
Contributor
Author
|
Was only the qodana fix :) Well.. at least I thought that :D |
ITaluone
force-pushed
the
fix/finish-2445
branch
2 times, most recently
from
159cd68 to
c021b6e
Compare
With latest, it crashes when trying to access the array members.
ITaluone
force-pushed
the
fix/finish-2445
branch
from
c021b6e to
92e40ed
Compare
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
jnyrup
reviewed
Dec 14, 2023
ITaluone
force-pushed
the
fix/finish-2445
branch
from
92e40ed to
70b200e
Compare
jnyrup
approved these changes
Dec 15, 2023
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…sertions#2511) * Fix issue when an empty ArraySegmnet is a member of a class. With latest, it crashes when trying to access the array members. * Fix PR comments. * Fix Qodana complaints * Update releases.md * Address review comments --------- Co-authored-by: Shahar Prish <shaharp@microsoft.com>
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…sertions#2511) * Fix issue when an empty ArraySegmnet is a member of a class. With latest, it crashes when trying to access the array members. * Fix PR comments. * Fix Qodana complaints * Update releases.md * Address review comments --------- Co-authored-by: Shahar Prish <shaharp@microsoft.com>
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…sertions#2511) * Fix issue when an empty ArraySegmnet is a member of a class. With latest, it crashes when trying to access the array members. * Fix PR comments. * Fix Qodana complaints * Update releases.md * Address review comments --------- Co-authored-by: Shahar Prish <shaharp@microsoft.com>
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 18, 2024
…sertions#2511) * Fix issue when an empty ArraySegmnet is a member of a class. With latest, it crashes when trying to access the array members. * Fix PR comments. * Fix Qodana complaints * Update releases.md * Address review comments --------- Co-authored-by: Shahar Prish <shaharp@microsoft.com>
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 3, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes #2445
Al the credit goes to @ShaharPrishMSFT
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome