Report mismatch segment for strings of unequal lengths #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you still working on this? If so, please prefix it it with |
krajek
changed the title
|
I think I am done with the first proposition. |
krajek
changed the title
dennisdoomen
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
Only minor comments. Check the legend for the meaning of the emojis.
| int indexOfMismatch = subject.IndexOfFirstMismatch(expected, comparisonMode); | ||
|
|
||
| // If there is no difference it means that subject and expected have common prefix | ||
| // and the first difference is after just that prefix. |
There was a problem hiding this comment.
❓ What do you mean with prefix here?
jnyrup
approved these changes
Sep 19, 2018
|
@krajek can we merge this? |
|
Yes, please. Thanks for the reviews. |
|
Awesome. Thanks man. |
krajek
deleted the
location_of_difference_for_strings_with_different_length
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #907.
I used the same mechanism to display differences as in part of the code that handles strings with equal lengths, with few adjustments.
BTW Possible follow-ups: