-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ThrowAsync
, ThrowExactlyAsync
and NotThrowAsync
#931
Add ThrowAsync
, ThrowExactlyAsync
and NotThrowAsync
#931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other exception assertions have the ThrowExactly
extension located in AssertionExtensions.Actions.cs
.
To provide the same set of assertions for the async version, ThrowExactlyAsync
should be added.
It would be nice with a test exercising that ThrowAsync<TException>
also works for derived types of TException
, like When_subject_throws_subclass_of_expected_exact_exception_it_should_fail
does.
1fe1a12
to
1d140fa
Compare
@jnyrup I have just added |
ThrowAsync
and NotThrowAsync
ThrowAsync
, ThrowExactlyAsync
and NotThrowAsync
1d140fa
to
d2de932
Compare
I have just completed fixes after the second review |
Any plans of release this soon? I just started using FluentAssertion and this is exactly what I needed. |
@nerdpad yes, we're also quite eager to get out a new release with all the new features, fixes and other improvements. |
Closes #851.