Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThrowAsync, ThrowExactlyAsync and NotThrowAsync #931

Merged
merged 4 commits into from Oct 1, 2018

Conversation

krajek
Copy link
Contributor

@krajek krajek commented Sep 29, 2018

Closes #851.

Copy link
Member

@jnyrup jnyrup left a comment

The other exception assertions have the ThrowExactly extension located in AssertionExtensions.Actions.cs.
To provide the same set of assertions for the async version, ThrowExactlyAsync should be added.

It would be nice with a test exercising that ThrowAsync<TException> also works for derived types of TException, like When_subject_throws_subclass_of_expected_exact_exception_it_should_fail does.

@krajek krajek force-pushed the throw_and_not_throw_async branch from 1fe1a12 to 1d140fa Compare Sep 29, 2018
@krajek
Copy link
Contributor Author

@krajek krajek commented Sep 29, 2018

@jnyrup I have just added ThrowExactlyAsync. Ready to merge from my side.

@krajek krajek changed the title Add ThrowAsync and NotThrowAsync Add ThrowAsync, ThrowExactlyAsync and NotThrowAsync Sep 29, 2018
@krajek krajek force-pushed the throw_and_not_throw_async branch from 1d140fa to d2de932 Compare Sep 30, 2018
@krajek
Copy link
Contributor Author

@krajek krajek commented Sep 30, 2018

I have just completed fixes after the second review

@jnyrup jnyrup merged commit 4982935 into fluentassertions:master Oct 1, 2018
1 check passed
@krajek krajek deleted the throw_and_not_throw_async branch Oct 1, 2018
@nerdpad
Copy link

@nerdpad nerdpad commented Oct 31, 2018

Any plans of release this soon? I just started using FluentAssertion and this is exactly what I needed.

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Oct 31, 2018

@nerdpad yes, we're also quite eager to get out a new release with all the new features, fixes and other improvements.
We're finishing up the last PRs for 5.5.0, see the remaining ones here https://github.com/fluentassertions/fluentassertions/milestone/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants