Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BeApproximately version for both subject and expected nullable #934

Merged
merged 3 commits into from Oct 2, 2018

Conversation

krajek
Copy link
Contributor

@krajek krajek commented Oct 1, 2018

Closes #922.

For now, I have tackled only the case of double?.
Please review. Upon approval, I will copy the logic and tests for float? and decimal?.

@krajek krajek changed the title [WIP]Add BeApproximately for both subject and expected of type double? [WIP] Add BeApproximately version for both subject and expected nullable Oct 1, 2018
jnyrup
jnyrup approved these changes Oct 1, 2018
@krajek krajek force-pushed the expected_numeric_nullable branch from 804f688 to 3f33cc2 Compare Oct 2, 2018
@krajek krajek force-pushed the expected_numeric_nullable branch from 675c41f to 612a1e3 Compare Oct 2, 2018
@krajek krajek changed the title [WIP] Add BeApproximately version for both subject and expected nullable Add BeApproximately version for both subject and expected nullable Oct 2, 2018
@krajek
Copy link
Contributor Author

@krajek krajek commented Oct 2, 2018

PR is ready.
Let me know what you think about NotBeApproximately(nullable, nullable[...]).
For me it makes sense, but it was not discussed not requested in the #922.
I will create another PR if we agree to add it.

@jnyrup jnyrup merged commit 42ef7d9 into fluentassertions:master Oct 2, 2018
1 check passed
@jnyrup
Copy link
Member

@jnyrup jnyrup commented Oct 2, 2018

@krajek to quote an incredible active contributor (hint, it's you!)

Good catch, thanks.

I didn't think about NotBeApproximately, but it makes good sense to add that as well the align the API overloads with BeApproximately.

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Oct 3, 2018

Yeah, I wonder where @krajek is getting the time from.... ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants