Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecutionTime acception async action #938

Merged
merged 1 commit into from Oct 7, 2018

Conversation

krajek
Copy link
Contributor

@krajek krajek commented Oct 4, 2018

Closes #858.
A simple generalization of ExecutionMethod allowed enough flexibility to support both Action and Func<Task.

@dennisdoomen dennisdoomen requested a review from jnyrup Oct 5, 2018
@krajek krajek force-pushed the async_execution_time branch from fc20316 to 0655213 Compare Oct 5, 2018
@krajek
Copy link
Contributor Author

@krajek krajek commented Oct 5, 2018

I have just adjusted the implementation. Instead of generalizing the code I just added separate ExecutionTime constructor accepting Func<Task>. Some code needed to be copied but I think @jnyrup was right in his review and synchronous and asynchronous cases should be handled separately.

Ready for merge.

@krajek
Copy link
Contributor Author

@krajek krajek commented Oct 5, 2018

BTW, follow up PR will deliver ExecutionTimeOf in async mode.

jnyrup
jnyrup approved these changes Oct 6, 2018
@dennisdoomen dennisdoomen merged commit 7be38a2 into fluentassertions:master Oct 7, 2018
1 check passed
@krajek krajek deleted the async_execution_time branch Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants