-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collection assertion ContainEquivalentOf #950
Conversation
50f3573
to
c8dd3a0
Compare
asserts that a collection contains at least one object that is equivalent to the expected object.
c8dd3a0
to
5b27bc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See http://dawehner.github.io/github,/code/review/2017/09/08/emoji-code-review.html for the meaning of the emojis
Feedback from PR.
39666a3
to
5426a12
Compare
48712d1
to
83053a3
Compare
Just two typos. The rest looks good. |
Should this be added to |
To verify that a dictionary contains a key-value pair which value is equivalent to the provided expectation? Maybe, but I don't think it belongs in this PR. It's not a consistency thing IMO. |
Ahh, yes of course. If one wants to assert that a dictionary contains an equivalent value, one can use dictionary.Values.Should().ContainEquivalentOf(expected); |
So it seems we can merge this one. |
I agree. I haven't been able to come up with a reason not to merge it. |
Hi, i just wanted to thank the two of you for your support with this PR. Especially @dennisdoomen, you made me realize just how much work maintaining an open source project is as you could have done this by yourself in no time but took the effort to support me in my doing. Thanks. |
Thanks for the kind words. |
I gave #584 a try.
A new collection assertion named ContainEquivalentTo so a collection can be asserted to contain an object that "IsEquivalentTo" an expected object.
Not sure about the documentation. Could be enough, but not sure.
BR Matthias