Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including and/or excluding properties in graph comparison should honor the declared type #960

Merged
merged 1 commit into from Nov 7, 2018

Conversation

dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Nov 5, 2018

Excluding or including a property with a certain name would include or exclude all properties with that name in the entire hierarchy, even those that are hidden by the new keyword.

Fixes #956

@dennisdoomen dennisdoomen force-pushed the Fix956 branch 2 times, most recently from 5455f2c to df5dbea Compare Nov 6, 2018
@dennisdoomen dennisdoomen changed the title [WIP] Including and/or excluding properties in graph comparison should honor the declared type Including and/or excluding properties in graph comparison should honor the declared type Nov 6, 2018
@dennisdoomen dennisdoomen requested a review from jnyrup Nov 6, 2018
jnyrup
jnyrup approved these changes Nov 7, 2018
Src/FluentAssertions/Common/MemberPath.cs Show resolved Hide resolved
Src/FluentAssertions/Common/MemberPath.cs Outdated Show resolved Hide resolved
Src/FluentAssertions/Common/MemberPath.cs Outdated Show resolved Hide resolved
@dennisdoomen dennisdoomen merged commit a144189 into fluentassertions:master Nov 7, 2018
1 check passed
@dennisdoomen dennisdoomen deleted the Fix956 branch Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants