Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows BeEquivalentTo to handle a non-generic collection as the SUT #975

Merged
merged 1 commit into from Nov 19, 2018

Conversation

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 18, 2018

The GenericEnumerableEquivalencyStep did not properly support the subject to be a non-generic collection.

Fixes #973

@dennisdoomen dennisdoomen requested a review from jnyrup Nov 18, 2018
@jnyrup
jnyrup approved these changes Nov 19, 2018
@@ -1598,30 +1616,6 @@ public void When_subject_is_null_and_expectation_is_enumerable_it_should_throw()
"Expected subject not to be <null>*");
}

[Fact]
public void When_the_expectation_is_not_a_multi_dimensional_array_it_should_throw()

This comment has been minimized.

Copy link
@jnyrup

jnyrup Nov 19, 2018

Collaborator

Why is this test no longer valid?

This comment has been minimized.

Copy link
@dennisdoomen

dennisdoomen Nov 19, 2018

Author Member

Because since v5, the expectation drives the type of comparison. Since it's a string, it'll never trigger the MultiDimensionalArrayEquivalencyStep

This comment has been minimized.

Copy link
@jnyrup

jnyrup Nov 19, 2018

Collaborator

Makes sense.
Couldn't see how that test should be affected by the other changes in this PR.

This comment has been minimized.

Copy link
@dennisdoomen

dennisdoomen Nov 19, 2018

Author Member

Don't even understand how this entire bug only surfaced now.

@dennisdoomen dennisdoomen merged commit d25c795 into fluentassertions:master Nov 19, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@dennisdoomen dennisdoomen deleted the dennisdoomen:fix973 branch Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.