Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted changes to AssertionScope to maintain binary compatibility #977

Merged

Conversation

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 20, 2018

In #925, some of the methods of AssertionScope were changed to return an IAssertionScope instead of the full class. However, this causes binary compatibility issues for libraries extending FluentAssertions. If such a library depended on a version between 5.0 and 5.5, upgrading to 5.5 would cause missing method exception. I've reverted those changes by exposing the IAssertionScope interface as explicit interface implementations.

This should fix fluentassertions/fluentassertions.json#27

@dennisdoomen dennisdoomen requested a review from jnyrup Nov 20, 2018
@dennisdoomen dennisdoomen changed the title Reverted changes to AssertionScope to ensure binary compatibility Reverted changes to AssertionScope to maintain binary compatibility Nov 20, 2018
@dennisdoomen

This comment has been minimized.

Copy link
Member Author

dennisdoomen commented Nov 20, 2018

Note: I decided not to change Continuation.Then since it would not be possible and it is very unlikely that a lot of people are using that one.

@jnyrup
jnyrup approved these changes Nov 20, 2018
Copy link
Collaborator

jnyrup left a comment

I tried yesterday to find projects on that depend on FA and looking at ~20-30 projects that looked like they could be extension libraries, none of them used Then.

@dennisdoomen dennisdoomen merged commit 9a36498 into fluentassertions:master Nov 20, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@dennisdoomen dennisdoomen deleted the dennisdoomen:FixApiCompatibility branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.