Permalink
Browse files

updated BigDecimal to play a bigger role that in previous commits, th…

…is is because we need to be in line with the DecimalType in Cassandra which uses the BigDecimal type in Java
  • Loading branch information...
nberardi committed May 14, 2012
1 parent 97eda39 commit 45e21d0737b94e2df7670819237d9636e5ff5f9e
@@ -245,7 +245,7 @@
<Compile Include="Thrift\Transport\TTransportFactory.cs" />
<Compile Include="Types\AsciiType.cs" />
<Compile Include="Types\AsciiTypeConverter.cs" />
- <Compile Include="Types\BigDecimal.cs" />
+ <Compile Include="System\Numerics\BigDecimal.cs" />
<Compile Include="Types\BytesTypeConverter.cs" />
<Compile Include="ColumnType.cs" />
<Compile Include="Types\BytesType.cs" />
Oops, something went wrong.

2 comments on commit 45e21d0

@Smoles

This comment has been minimized.

Show comment Hide comment
@Smoles

Smoles May 14, 2012

Hey Nick. Do you think it's appropriate to add BigDecimal to the System.Numerics namespace? Won't this cause conflicts if Microsoft ever decides to add this data type in a future version of .Net?

Hey Nick. Do you think it's appropriate to add BigDecimal to the System.Numerics namespace? Won't this cause conflicts if Microsoft ever decides to add this data type in a future version of .Net?

@nberardi

This comment has been minimized.

Show comment Hide comment
@nberardi

nberardi May 14, 2012

Contributor

They have no plans to do anything with the System.Numerics namespace. Which is half the problem. So I believe it is pretty safe. If it happens I will remove and release a new library that uses Microsoft's implimentation, which should make it possible for people to keep existing code with out the need to rewrite.

Plus another reason it doesn't matter, if they ever add it to System.Numerics.

Since my implementation relies on System.Numerics.BigInteger there would still be a type conflict unless the user has always referenced in their code as {Namespace} + BigDecimal.and System.Numerics.BigInteger. Because if the user just referenced them as BigDecimal there would be a type conflict between BigDecimal even if the namespaces were different.

Contributor

nberardi replied May 14, 2012

They have no plans to do anything with the System.Numerics namespace. Which is half the problem. So I believe it is pretty safe. If it happens I will remove and release a new library that uses Microsoft's implimentation, which should make it possible for people to keep existing code with out the need to rewrite.

Plus another reason it doesn't matter, if they ever add it to System.Numerics.

Since my implementation relies on System.Numerics.BigInteger there would still be a type conflict unless the user has always referenced in their code as {Namespace} + BigDecimal.and System.Numerics.BigInteger. Because if the user just referenced them as BigDecimal there would be a type conflict between BigDecimal even if the namespaces were different.

Please sign in to comment.