Timeout parameters in CassandraContext and ConnectionBuilder are ambiguous #116

Open
kmbnw opened this Issue Feb 26, 2013 · 2 comments

Projects

None yet

2 participants

@kmbnw
kmbnw commented Feb 26, 2013

This is minor, but given that int timeout parameters are (in general) often in milliseconds, I was surprised to see that "timeout" in CassandraContext and "connectionTimeout" in ConnectionBuilder are in seconds:

ConnectionTimeout = TimeSpan.FromSeconds(connectionTimeout);

Would it be possible to do one of the following:

  • Rename those parameters to indicate seconds
  • Use a TimeSpan instead
  • Put a docstring on so that one doesn't have to dig through layers of code to discover what units those parameters are

The project I am using FluentCassandra for is still resolving its open source contribution policy, hence the bug rather than a pull request.

Thanks

@nberardi
Contributor

I would be happy to accept a pull request with an additional constructor that had the connectionTimeout and others as TimeSpan types.

@kmbnw
kmbnw commented Feb 26, 2013

OK, I'll get something together as soon as the policy I mentioned above gets resolved. Thanks.

@nberardi nberardi was assigned Apr 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment